Skip to content

feat: adopt the final shape of EIP-2780 (Amsterdam) - #1886

Merged
anaPerezGhiglia merged 3 commits into
feat/amsterdam-revm-upgradefrom
feat/eip-2780-final-numbers
Oct 26, 2026
Merged

anaPerezGhiglia merged 3 commits into
feat/amsterdam-revm-upgradefrom
feat/eip-2780-final-numbers

Conversation

@anaPerezGhiglia

@anaPerezGhiglia anaPerezGhiglia commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

👀 Targets the feat/amsterdam-revm-upgrade feature branch, not main


Announces and pins the EIP-2780 side of the revm 43 bump (#1847): the bump already carries the numbers, this PR adds the tests on receipts and eth_estimateGas and the changeset.

revm 43 (bluealloy/revm#3850) reprices the EIP-2780 intrinsic gas; revm computes it and EDR only passes the transaction's Eip2780TxInfo, so there is no EDR code change:

  • TX_VALUE_COST 4,244 → 6,000, absorbing the removed TRANSFER_LOG_COST (1,756): a value transfer to an existing account still costs the flat 21,000 (TX_BASE_COST 12,000 + COLD_ACCOUNT_ACCESS 3,000 + TX_VALUE_COST 6,000). The bump branch already re-baselined the test's named sum.
  • Contract-creation transactions no longer pay any value-based charge, as the EIP specifies: 24,000 flat (TX_BASE_COST 12,000 + CREATE_ACCESS 12,000) plus init code and state gas. revm 42 charged TRANSFER_LOG_COST on a creation with value.

@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 20:04 — with GitHub Actions Inactive
@changeset-bot

changeset-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d99300f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@nomicfoundation/edr Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anaPerezGhiglia
anaPerezGhiglia requested a balanced review from Copilot October 22, 2026 20:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused test and release-note changes match the upstream repricing and existing estimator behavior, with no unresolved issues identified.

No open issues 🎉

What changed in this PR

Adds regression coverage and a release note for the final EIP-2780 gas pricing already supplied by the revm 43 upgrade. No EDR runtime logic changes.

Changes:

  • Tests receipt gas costs for value transfers and contract creation with value.
  • Tests eth_estimateGas for transfers to new and existing accounts, and reuses creation helpers.
  • Documents the removal of value charges for contract-creation transactions from Amsterdam.
File Description
crates/​edr_provider/​tests/​integration/​eip2780.rs Adds gas-pricing regression tests and shared transaction helpers.
.changeset/​eip2780-create-value-charge.md Adds a patch release note for Amsterdam creation pricing.

Review effort: Balanced

@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 20:07 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia temporarily deployed to github-action-benchmark October 22, 2026 20:07 — with GitHub Actions Inactive
@anaPerezGhiglia
anaPerezGhiglia marked this pull request as ready for review October 22, 2026 20:08
@anaPerezGhiglia
anaPerezGhiglia requested a review from a team October 22, 2026 20:08
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/amsterdam-revm-upgrade@84f8ebd). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat/amsterdam-revm-upgrade    #1886   +/-   ##
==============================================================
  Coverage                               ?   81.02%           
==============================================================
  Files                                  ?      474           
  Lines                                  ?    84026           
  Branches                               ?    84026           
==============================================================
  Hits                                   ?    68085           
  Misses                                 ?    13658           
  Partials                               ?     2283           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wodann
Wodann requested review from Wodann and removed request for a team October 23, 2026 04:48

@Wodann Wodann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, pending some suggested modifications.

Comment thread .changeset/eip2780-create-value-charge.md Outdated
Comment thread .changeset/eip2780-create-value-charge.md Outdated
Comment thread crates/edr_provider/tests/integration/eip2780.rs Outdated
Comment thread crates/edr_provider/tests/integration/eip2780.rs Outdated
Comment thread crates/edr_provider/tests/integration/eip2780.rs Outdated
Comment thread crates/edr_provider/tests/integration/eip2780.rs Outdated
Comment thread crates/edr_provider/tests/integration/eip2780.rs
Comment thread crates/edr_provider/tests/integration/eip2780.rs
@anaPerezGhiglia
anaPerezGhiglia deployed to github-action-benchmark October 26, 2026 15:51 — with GitHub Actions Active
@anaPerezGhiglia
anaPerezGhiglia deployed to github-action-benchmark October 26, 2026 15:54 — with GitHub Actions Active
@anaPerezGhiglia
anaPerezGhiglia deployed to github-action-benchmark October 26, 2026 16:16 — with GitHub Actions Active
@anaPerezGhiglia
anaPerezGhiglia deployed to github-action-benchmark October 26, 2026 16:19 — with GitHub Actions Active
@anaPerezGhiglia
anaPerezGhiglia merged commit 5e923dc into feat/amsterdam-revm-upgrade Oct 26, 2026
62 of 63 checks passed
@anaPerezGhiglia
anaPerezGhiglia deleted the feat/eip-2780-final-numbers branch October 26, 2026 17:31

This branch had an error being deployed

1 failed deployment
github-action-benchmark — d99300fd Deployed Oct 26, 2026 by anaPerezGhiglia via Run JS Solidity test runner benchmark #5953
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants