Repository navigation
feat: adopt the final shape of EIP-2780 (Amsterdam) - #1886
Conversation
🦋 Changeset detectedLatest commit: d99300f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🟢 Approval recommended
The focused test and release-note changes match the upstream repricing and existing estimator behavior, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Adds regression coverage and a release note for the final EIP-2780 gas pricing already supplied by the revm 43 upgrade. No EDR runtime logic changes.
Changes:
- Tests receipt gas costs for value transfers and contract creation with value.
- Tests
eth_estimateGasfor transfers to new and existing accounts, and reuses creation helpers. - Documents the removal of value charges for contract-creation transactions from Amsterdam.
| File | Description |
|---|---|
crates/edr_provider/tests/integration/eip2780.rs |
Adds gas-pricing regression tests and shared transaction helpers. |
.changeset/eip2780-create-value-charge.md |
Adds a patch release note for Amsterdam creation pricing. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/amsterdam-revm-upgrade #1886 +/- ##
==============================================================
Coverage ? 81.02%
==============================================================
Files ? 474
Lines ? 84026
Branches ? 84026
==============================================================
Hits ? 68085
Misses ? 13658
Partials ? 2283 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Wodann
left a comment
There was a problem hiding this comment.
Approved, pending some suggested modifications.
5e923dc
into
feat/amsterdam-revm-upgrade
👀 Targets the
feat/amsterdam-revm-upgradefeature branch, notmainAnnounces and pins the EIP-2780 side of the revm 43 bump (#1847): the bump already carries the numbers, this PR adds the tests on receipts and
eth_estimateGasand the changeset.revm 43 (bluealloy/revm#3850) reprices the EIP-2780 intrinsic gas; revm computes it and EDR only passes the transaction's
Eip2780TxInfo, so there is no EDR code change:TX_VALUE_COST4,244 → 6,000, absorbing the removedTRANSFER_LOG_COST(1,756): a value transfer to an existing account still costs the flat 21,000 (TX_BASE_COST12,000 +COLD_ACCOUNT_ACCESS3,000 +TX_VALUE_COST6,000). The bump branch already re-baselined the test's named sum.TX_BASE_COST12,000 +CREATE_ACCESS12,000) plus init code and state gas. revm 42 chargedTRANSFER_LOG_COSTon a creation with value.