Repository navigation
[Backport 2.30-maintenance] installer: Fix store mtime - #16566
Merged
Merged
Conversation
This uncovers a latent bug in the tests: `MAYBESUDO: unbound variable` dating back to 717e81d. `sudo` was never actually needed and root's channel was never modified because the undefined variable was expanded on the host and not the VM under test. Keeping the test's behavior the same, we can safely remove the entire MAYBESUDO machinery without functional changes. (cherry picked from commit 33a7ac4)
…taller repo Aligns the test better to what's in the nix-installer repo and adds support for custom checks for cases with some common tests. (cherry picked from commit a8d51fa)
It's 1, not 0 (see mtimeStore). Also busybox tar is busted at preserving mtime, so hack around the issue by setting the correct mtime ourselves. (cherry picked from commit 4620eab)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Manual backport of #16558.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.