Conversation
Contributor
Greptile SummaryThis PR adds an NFD engine that publishes topology through Node Feature Discovery resources. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (5): Last reviewed commit: "feat(engine/nfd): publish topology as NF..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 72.15% 72.83% +0.67%
==========================================
Files 89 94 +5
Lines 5689 6235 +546
==========================================
+ Hits 4105 4541 +436
- Misses 1382 1461 +79
- Partials 202 233 +31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pull-request-402.docs.buildwithfern.com/topograph |
5493077 to
45b9d3c
Compare
Signed-off-by: Dmitry Shmulevich <dshmulevich@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an NFD engine that translates the canonical topology graph into
NodeFeature and NodeFeatureGroup resources.
Publish accelerator, leaf, spine, and core topology attributes, including the
system node name required for NFD to populate group membership. Support node
selection, namespaced NFD installations, stale-resource cleanup, and existing
GPU clique labels.