DLESYM pdates - #1827
Conversation
Bring over modulus-uw dev changes through optimized CLN (94b785f), remapping dlwp_healpix_layers to dlwp_healpix/layers and aligning HEALPix ops with physicsnemo.nn.module.hpx. Includes Zarr datapipes, hydrostatic loss, CLN/checkpointing, and related tests.
for more information, see https://pre-commit.ci
Greptile SummaryThis PR updates the DLESyM HEALPix model stack and adds Zarr-backed data support. The main changes are:
Important Files Changed
Reviews (1): Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." | Re-trigger Greptile |
|
Great work!! Minor comments. Also, thanks for walking me through the changes. |
|
Hey @daviddpruitt , most comments are with regards to coupler changes. other than that it looks good to me. |
…o adapt time dimension based on batch size
…nostic model in HEALPixUNet.py
|
/codeowners-info |
1 similar comment
|
/codeowners-info |
CODEOWNERS review mapCurrent for commit ⏳ @coreyjadams — 4 file(s)
⏳ @loliverhennigh — 1 file(s)
⏳ @pzharrington — 12 file(s)
No CODEOWNER
Comment |
coreyjadams
left a comment
There was a problem hiding this comment.
I have left a few comments that are very minor but need to be addressed for downstream users who might not be working with pandas and xarray, but want to run tests. Currently, this will break their development. Please address them before merge?
loliverhennigh
left a comment
There was a problem hiding this comment.
The module stuff looks fine to me
|
/ok to test 442a354 |
PhysicsNeMo Pull Request
Description
Updates DLESyM architectures and features.
HEALPixRecUNetandHEALPixUNetUNetEncoderand DLESyMUNetDecoderHEALPixRecUNetandHEALPixUNetNonnegativeConstraintaddedSymmetricConvNeXtBlock,Multi_SymmetricConvNeXtBlock,DoubleConvNeXtBlock,ConvGRUBlock,ConvNeXtBlock,BasicConvBlock,TransposedConvUpsample,InterpolateConditionalWeightLoss,WeightedCRPSLoss, andWeightedCRPSLossSpectralChecklist
Dependencies
No new dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.