Conversation
nvzm123
marked this pull request as draft
September 19, 2026 02:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This isolates the bounded post-ingest HNSW optimizations previously developed alongside #2481 and #2594. GPU CAGRA construction remains serialized;
writerThreadsnow also controls bounded CPU work after construction.Changes
writerThreadsthrough ordinary, binary-quantized, and scalar-quantized accelerated writers.writerThreadsbehavior and memory bounds.Validation
mvn -o spotless:check install: 352 tests, 0 failures/errors, 30 skippedwriterThreads=1: 1,000,000 documents/vectors and 32,000,000 validated arcswriterThreads=16: 1,000,000 documents/vectors and 32,000,000 validated arcswriterThreads=16: 1,000,000 documents/vectors, four leaves, and 32,000,000 validated arcsCheckIndex -level 2and completed 980 measured queries after 20 warmupsgit diff --checkpassedThe Deep1B runs are functional sanity checks, not controlled performance measurements.
Integration note
This branch is based directly on
mainand contains only the post-ingest optimization. If #2476 lands first, this change needs a semantic rebase so that #2476's newer ownership, validation, and upper-layer fixes are retained.