Conversation
The depends list located the _cpp headers relative to the current directory. Anchor it on the module's own path so it does not assume the process runs inside cuda_core. Follow-up to a review comment on NVIDIA#2837. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
@mdboom Following up on your suggestion from #2837 (#2837 (comment)). Applying it as-is fails CI on every platform, and I want to understand your workflow before deciding how to proceed. What breaks: You mentioned the relative path breaks your workflow. How are you invoking the build when the current directory is not
Happy to take whichever you think is right. |
It looks like build isolation is taking care of making this work these days anyway, so perhaps this isn't needed after all. |
|
Thanks, that answers it. |
Summary
Follow-up to #2837: applies the review suggestion in #2837 (comment).
_extension_depends()located the_cppheaders relative to the current directory; it now anchors on the location ofbuild_hooks.py, so the depends list does not assume the process runs insidecuda_core.The other relative paths in
build_hooks.py(the.pyxglob,_extension_sources(),include_dirs) stay cwd-relative on purpose: cythonize mirrors the relative source path underbuild/, and the backend already converts absolute sources back to relative paths for that reason. PEP 517 frontends run the backend inside the project directory, so those hold under every supported build.🤖 Generated with Claude Code