Repository navigation
Conversation
Add validation-only mode for policy updates. When --dry-run is set, the gateway runs all validation checks (safety, static field immutability, global lock) and returns a diff of network rule changes without persisting the revision or notifying the sandbox. - Add dry_run field to UpdateConfigRequest proto - Add dry_run, added_network_rules, removed_network_rules to UpdateConfigResponse proto - Add PolicyDiff utility in openshell-core for comparing network rules between two SandboxPolicy protos - Refactor handle_update_config to skip DB writes and sandbox notification when dry_run=true - Add --dry-run flag to CLI policy set (sandbox and global) - Incompatible with --wait since dry-run does not apply the policy - Update architecture and user-facing docs Signed-off-by: JoeVenner <ylafrimi@gmail.com>
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
|
Thank you for your interest in contributing to OpenShell, @joeVenner. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation-only mode for policy updates. When --dry-run is set, the gateway runs all validation checks (safety, static field immutability, global lock) and returns a diff of network rule changes without persisting the revision or notifying the sandbox.
Summary
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist