Skip to content

fix(ci): isolate untrusted workflow execution - #4616

Open
alangou wants to merge 2 commits into
mainfrom
fix/042-workflow-permissions/alangou
Open

alangou wants to merge 2 commits into
mainfrom
fix/042-workflow-permissions/alangou

Conversation

@alangou

@alangou alangou commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Run approved pull request revisions through trusted default-branch workflow definitions with read-only candidate jobs. Pass pull request images to E2E jobs as workflow artifacts while keeping registry publication in trusted release workflows.

Related Issue

Internal tracking: 042 (private review).

Changes

  • Require exact-SHA maintainer authorization before candidate checkout and bind required statuses to the exact dispatched runs
  • Replace mirrored-branch execution with trusted dispatch and verified merge-queue reconciliation
  • Build pull request images without registry credentials and load them from workflow artifacts
  • Harden workflow provenance, cache access, and release-canary authorization
  • Update CI and contributor guidance and add regression coverage for workflow isolation and status serialization

Before enabling fork approvals or enqueueing fork pull requests, activate and test the organization-level required workflow rule documented in CI.md.

Testing

  • mise run test:pr-workflow-security (14 passed)
  • Dynamic JavaScript status aggregation and serialization checks
  • Ruff and git diff --check
  • Unit tests added/updated
  • E2E suite execution (requested with test:e2e)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (CI.md and contributor skills)

Signed-off-by: Adrien Langou <alangou@nvidia.com>
Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou alangou added the test:e2e Requires end-to-end coverage label Oct 15, 2026
@alangou alangou added the gator:in-review Gator is reviewing or awaiting PR review feedback label Oct 15, 2026
@alangou
alangou requested a review from a team as a code owner October 15, 2026 17:39
@copy-pr-bot

copy-pr-bot Bot commented Oct 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/4616 does not exist yet. A maintainer needs to comment /ok to test dda2163606c4e7a25b6b6e7799cca5c322c63653 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@github-actions

Copy link
Copy Markdown

Comment on lines +9 to +18
on:
issue_comment:
types: [created]
pull_request_target:
types: [opened, synchronize, labeled, unlabeled, ready_for_review, reopened, enqueued, dequeued]
push:
branches: [main]
schedule:
- cron: "*/5 * * * *"
workflow_dispatch:

@github-advanced-security github-advanced-security AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gator:in-review Gator is reviewing or awaiting PR review feedback test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants