Skip to content

refactor(prover): drop unused reachability state - #4024

Open
ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:refactor/2412-prover-dead-state
Open

ericcurtin wants to merge 1 commit into
NVIDIA:mainfrom
ericcurtin:refactor/2412-prover-dead-state

Conversation

@ericcurtin

Copy link
Copy Markdown
Contributor

Summary

Remove prover solver state that no query reads, and share the repeated encoding code.

Related Issue

Closes #2412

Changes

  • Drop binary_can_write, credential_has_write, credential_has_destructive, filesystem_readable and can_write_to_endpoint (no callers; the README says the crate is not a stable SDK)
  • Add endpoint_ports and fixed_bool helpers in place of three copied loops and five assert blocks
  • Fix the README model layout

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Prover, prover-cli and gateway policy tests pass. New test pins can_exfil_via_endpoint results.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@mrunalp @drew PTAL when you get a chance, and /ok to test 868c4fb37e4d4e753b4883ad1a200584f3899e44 if it looks good. Thank you!

@SDAChess

SDAChess commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

/ok to test 868c4fb

@ericcurtin

Copy link
Copy Markdown
Contributor Author

@johntmyers @SDAChess PTAL when you get a chance. Thank you!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(prover): remove legacy unused reachability constraints

2 participants