Repository navigation
fix(e2e): keep locally built Kubernetes images off the chart's default registry - #3991
Merged
Merged
Conversation
krishicks
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 30, 2026 19:33
…t registry 679b190 added global.image.registry (ghcr.io/nvidia) as the fallback for empty per-image registries and split e2e image references into registry and repository. Locally built images such as openshell/gateway:<tag> have no registry host, so the chart rewrote them to ghcr.io/nvidia/openshell/* and the k3d cluster could not pull them. Clear global.image.registry in the Kubernetes e2e wrapper, which sets every image's registry explicitly. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
hicks/push-lwlyvnynutpt
branch
from
September 30, 2026 19:35
cf3662a to
1561589
Compare
krishicks
enabled auto-merge
September 30, 2026 19:45
matthewgrossman
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local Kubernetes e2e runs that build their own images fail at Helm install because the chart pulls
ghcr.io/nvidia/openshell/*instead of the images imported into k3d. This is a regression from 679b190 (#3341), which addedglobal.image.registry(ghcr.io/nvidia) as the fallback for empty per-image registries and split e2e image references into registry and repository. Locally built images such asopenshell/gateway:<tag>have no registry host, so the chart rewrote them toghcr.io/nvidia/openshell/gateway:<tag>.Related Issue
No issue required: localized fix to the e2e wrapper.
Changes
global.image.registryin the Kubernetes e2e wrapper's Helm image args. The wrapper sets every image's registry explicitly, so an empty per-image registry now means none.Testing
mise run pre-commitpassesUnit tests added/updated
E2E tests added/updated (if applicable)
Rendered the chart with the wrapper's image args. With local tags, main rewrites the gateway, supervisor, and sandbox runtime images to
ghcr.io/nvidia/openshell/*; with this change they keep their local names. CI-styleghcr.io/nvidia/openshell/*references render unchanged.mise run e2e:kubernetes:workspace-operatorwithoutOPENSHELL_REGISTRYinstalls and passes (6/6). On main it fails at Helm install with an image pull error.Checklist