Repository navigation
feat(helm): add sandbox UID and GID values - #3947
Conversation
Closes NVIDIA#2697 Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
If useful, please also try https://github.com/llmmanorg/llmman, which can launch agents in an OpenShell sandbox ( |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This accepted Helm improvement is well scoped and includes the relevant Fern documentation, but the new scalar validator silently accepts a boolean as UID or GID 1.
Action required: Reject boolean values before numeric conversion and add a regression test for the shared UID/GID helper.
Blocking findings:
GATOR-6a07ea84-01: boolean identity values are coerced instead of rejected.
Carried findings:
- None
Gator metadata
- Validation: Implements accepted issue #2697 with a concentrated Helm chart change.
- Docs: Fern configuration and runtime docs updated; navigation changes are not needed.
- Checks: Review feedback must be resolved before required test dispatch.
- E2E:
test:e2eis required for this Helm/Kubernetes behavior after review feedback is resolved. - Head SHA:
6a07ea843be6b42ff15d4c6c1f0c22247dcbce7e - Base SHA:
b8ffe5244cb244a1d74a4a03d69afe3da07e5f08 - Merge base SHA:
b8ffe5244cb244a1d74a4a03d69afe3da07e5f08 - Patch ID:
d732ea9a73a64cce9371b02cf7dc4121001deb1e - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
Signed-off-by: Eric Curtin <eric.curtin@docker.com>
|
Label |
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
Thanks @ericcurtin. I checked your boolean-validation fix and the new UID and GID regression cases against the prior finding; GATOR-6a07ea84-01 is resolved, and the bounded follow-up review found no new blockers.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Gator metadata
- Validation: Implements accepted issue #2697 with a concentrated Helm chart change.
- Docs: Fern configuration and runtime docs are updated; navigation changes are not needed.
- Checks: Required current-head test dispatch is in progress.
- E2E:
test:e2eis applied; Gator is waiting for the label-help workflow to dispatch the required current-head jobs. - Head SHA:
ca73dcf6035208e395eebb902dc767f2d9c7df7d - Base SHA:
b8ffe5244cb244a1d74a4a03d69afe3da07e5f08 - Merge base SHA:
b8ffe5244cb244a1d74a4a03d69afe3da07e5f08 - Patch ID:
787925d5c36070887ca912affb4e4e62b7df00a8 - Gator payload:
9 - Review mode:
follow_up - Previous reviewed SHA:
6a07ea843be6b42ff15d4c6c1f0c22247dcbce7e - Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
|
/ok to test ca73dcf |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: the PR reached I removed the active |
Summary
Add
server.sandboxUidandserver.sandboxGidHelm values, rendered assandbox_uidandsandbox_gid.Related Issue
Closes #2697
Changes
Testing
mise run pre-commitpassesmise run helm:test,helm:lintandhelm:docs:checkpass.Checklist