refactor(providers): remove profile telemetry buckets - #3914
Draft
johntmyers wants to merge 1 commit into
Draft
johntmyers wants to merge 1 commit into
johntmyers wants to merge 1 commit into
Conversation
Remove the static inference provider table and stop emitting profile identity in provider lifecycle events. Keep operation and outcome for aggregate reporting. Refs #3906 Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
6 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-3914.docs.buildwithfern.com/openshell |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the static inference provider table and retire profile identity from provider lifecycle telemetry. Provider events continue to report operation and outcome, so adding an example YAML profile requires no telemetry registration or table row.
Related Issue
Refs #3906. This is a draft until the telemetry collector/report owner confirms that events without
providerProfileare accepted alongside historical events with it.Changes
providerProfileparameter from the core event payload.openshell profile listfor the imported catalog, and update the published telemetry description.Deviations from Plan
The current
mainbranch has noarchitecture/directory, so the documentation update is limited to the relevant published docs. The plan comment was revised to reflect that.Testing
cargo test -p openshell-core --lib telemetry(11 passed)cargo test -p openshell-core --lib --no-default-features telemetry(2 passed)cargo test -p openshell-server --lib grpc::provider::tests(156 passed)mise run pre-commitmise run ciThe first
mise run testattempt lacked localmke2fs; after installing it, a supervisor-network test timed out, including when run alone. The same test passed in the subsequent fullmise run cirun. No e2e files or sandbox infrastructure changed.Checklist