docs(first-agent): explain proposal refresh and rule approve-all - #3908
Closed
fede-kamel wants to merge 2 commits into
Closed
fede-kamel wants to merge 2 commits into
fede-kamel wants to merge 2 commits into
Conversation
Approving one proposal refreshes the evaluation of the others, so a second rule approve fails with "proposal inputs changed; evaluation refreshed" until the proposal is fetched and reviewed again. Explain this in step 4 and show rule approve-all. Refs NVIDIA#3884 Signed-off-by: fede-kamel <fkamelhar@gmail.com>
fede-kamel
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 29, 2026 21:44
rule approve-all skips security-flagged proposals unless --include-security-flagged is passed, and skips proposals whose evaluation changed since they were listed. Say so instead of implying it approves every pending proposal. Refs NVIDIA#3884 Signed-off-by: fede-kamel <fkamelhar@gmail.com>
fede-kamel
marked this pull request as draft
September 29, 2026 21:51
Contributor
Author
|
Superseded by #3923, which fixes the gateway so sequential approvals work instead of documenting the failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Approving one proposal refreshes the evaluation of the others, so a second
rule approvefails with "proposal inputs changed; evaluation refreshed". Explain this in the first-agent guide and showrule approve-all.Related Issue
Refs #3884 (docs mitigation; the CLI error UX itself is not changed here)
Changes
docs/about/run-your-first-agent.mdx: explain proposal refresh in step 4 and documentrule approve-all, including that it skips security-flagged proposals (unless--include-security-flagged) and proposals whose evaluation changed.Testing
mise run docs(nav check +fern check) passes with 0 errors on this branch merged with main.mise run pre-commitpassesChecklist