Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43,080 changes: 37,135 additions & 5,945 deletions ATTRIBUTIONS-Rust.md

Large diffs are not rendered by default.

3,077 changes: 2,654 additions & 423 deletions Cargo.lock

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@

[workspace]
members = [
"crates/fabric-runtime-control",
"crates/fabric-core",
"crates/fabric-cli",
"crates/fabric-python",
"environment-providers/openshell",
]
default-members = [
"crates/fabric-core",
Expand All @@ -16,6 +18,7 @@ resolver = "2"
[workspace.package]
version = "0.5.0"
edition = "2024"
rust-version = "1.88"
license = "Apache-2.0"
repository = "https://github.com/NVIDIA/nemo-fabric"

Expand Down
1 change: 1 addition & 0 deletions crates/fabric-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
name = "nemo-fabric-core"
version.workspace = true
edition.workspace = true
rust-version.workspace = true
license.workspace = true
repository.workspace = true
description = "Core config and runtime contract for NeMo Fabric."
Expand Down
12 changes: 7 additions & 5 deletions crates/fabric-core/src/doctor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ fn check_resolution(plan: &RunPlan) -> DoctorCheck {
"selected resolution strategy `service` is modeled but not implemented by NeMo Fabric runtime execution".to_string()
}
DoctorStatus::Warn => format!(
"selected resolution strategy `{resolution:?}` is declared but not executed by this POC"
"selected resolution strategy `{resolution:?}` is declared but not executed by this implementation"
),
DoctorStatus::Fail => unreachable!("resolution check never fails directly"),
};
Expand Down Expand Up @@ -274,7 +274,7 @@ fn check_requirements(plan: &RunPlan) -> Vec<DoctorCheck> {
"requirements.resolution",
DoctorStatus::Warn,
format!(
"requirements are declared for `{}` but this POC does not execute that resolution strategy",
"requirements are declared for `{}` but this implementation does not execute that resolution strategy",
resolution_name(plan.resolution)
),
)];
Expand Down Expand Up @@ -341,14 +341,16 @@ fn check_requirements(plan: &RunPlan) -> Vec<DoctorCheck> {
checks.push(check(
"requirement.service",
DoctorStatus::Warn,
format!("service requirement `{service}` is declared but not probed by this POC"),
format!(
"service requirement `{service}` is declared but not probed by this implementation"
),
));
}
for hook in &descriptor.requirements.plugin_hooks {
checks.push(check(
"requirement.plugin_hook",
DoctorStatus::Warn,
format!("plugin hook `{hook}` is declared but not probed by this POC"),
format!("plugin hook `{hook}` is declared but not probed by this implementation"),
));
}
checks
Expand Down Expand Up @@ -383,7 +385,7 @@ fn non_local_preinstalled_check(plan: &RunPlan) -> Option<DoctorCheck> {
"requirements.environment",
DoctorStatus::Warn,
format!(
"`preinstalled` requirements are expected inside `{}` and are not probed by this POC",
"`preinstalled` requirements are expected inside `{}` and are not probed by this implementation",
environment.provider
),
))
Expand Down
Loading
Loading