Add Italian comics support - #599
Merged
Merged
Conversation
Adds Publisher.alt_names, Series.language, and widens Issue.price's max_digits to accommodate non-USD cover prices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds initial support for Italian comics, as discussed in #595:
Schema
Publisher.alt_names— array field for alternative publisher names (mirrorsSeries.alt_names), with a matching GIN trigram indexSeries.language— ISO 639-1 language code, defaults to"en"Issue.price/Variant.price—max_digitswidened from 5 to 8 to support larger cover price amountsCURRENCIES(settings) — addsEURandITLalongsideUSD/GBP; this is a project-widedjmoneysetting, soCollectionItem.purchase_price_currencyandWishListItem.max_price_currencypicked up matching migrations tooCOUNTRIES(settings) — new setting (US,GB,IT) backingPublisherForm's country validation, replacing a hardcoded setAdmin / forms / filters
alt_namesandlanguagewired intoPublisherAdmin/SeriesAdminand their formsSeriesForm.clean_languageandPublisherForm.clean_countryrestrict the web UI to the currently-supported set (en/it,US/GB/IT) — the API itself is intentionally left unrestricted, since existing data already includes publishers outside that set (e.g.CA,FR)PublisherFilter(API) withalt_namesand aqquick-search filter acrossname/alt_names, mirroringSeriesFilteralt_nameslanguagefilter added toSeriesFilter/SeriesViewFilter, including the web UI's advanced-filters dropdown and active-filter chipsTemplates
API
alt_namesexposed onPublisherSerializer;languageexposed onSeriesSerializerand the nestedseriesobject inIssueSerializer(so MetronInfo.xml writers can read it from the issue detail endpoint)api/README.mdupdated throughout (new fields/filters, corrected a stale claim that the API restrictedcountrytoUS/GB, documented previously-undocumented Variantprice/price_currencyfields, new "Version 1.10" changelog entry)i18n
locale/it/LC_MESSAGES/django.poupdated with the new/changed strings this branch introducesChecklist
pytest)ruff check . --fix && ruff format .)locale/it/LC_MESSAGES/django.powas updated