Skip to content

Add condition so readOnly child cannot be added from parent #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xkello wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add condition so readOnly child cannot be added from parent #4688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/qml/form/editors/MMFormGalleryEditor.qml
View file
Open in desktop

@Withalion Withalion Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add a special case here when no pictures are linked and no are available to link

Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ MMPrivateComponents.MMBaseInput {
}
}

header: __activeProject.projectRole !== "reader" ? addFeatureComponent : null
header: (__activeProject.projectRole !== "reader" && !rmodel?.layer.readOnly) ? addFeatureComponent : null

@Withalion Withalion Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
header: (__activeProject.projectRole !== "reader" && !rmodel?.layer.readOnly) ? addFeatureComponent : null
header: (__activeProject.projectRole !== "reader" && !rmodel?.layer?.readOnly) ? addFeatureComponent : null

}

Component {
Expand Down
2 changes: 1 addition & 1 deletion app/qml/form/editors/MMFormRelationEditor.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ MMPrivateComponents.MMBaseInput {
height: privates.itemHeight
radius: 8 * __dp
color: __style.lightGreenColor
visible: __activeProject.projectRole !== "reader"
visible: (__activeProject.projectRole !== "reader" && !rmodel?.layer.readOnly)

@Withalion Withalion Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
visible: (__activeProject.projectRole !== "reader" && !rmodel?.layer.readOnly)
visible: (__activeProject.projectRole !== "reader" && !rmodel?.layer?.readOnly)


MMComponents.MMIcon {
anchors.centerIn: parent
Expand Down
Loading