Skip to content

fix(web_fetch): report transport failure causes - #29

Merged
sheperdh merged 2 commits into
memoryboxfrom
codex/report-web-fetch-causes
Sep 17, 2026
Merged

sheperdh merged 2 commits into
memoryboxfrom
codex/report-web-fetch-causes

Conversation

@sheperdh

@sheperdh sheperdh commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • classify web_fetch request and response-body failures while preserving the existing stable error prefixes
  • expose the deepest transport cause to the tool result and emit a bounded full source chain in structured logs
  • add connection, timeout, and diagnostic-size regression coverage

Validation

  • cargo fmt --all -- --check
  • cargo test -p zeroclaw-tools web_fetch::tests
  • cargo clippy -p zeroclaw-tools --all-targets --no-deps -- -D warnings -A clippy::useless-format

The unmodified workspace-wide clippy gate is currently blocked by an existing chunks_exact_to_as_chunks lint in zeroclaw-memory/src/vector.rs. The full zeroclaw-tools suite has four unrelated environment/concurrency failures.

@Kevin-K-W Kevin-K-W left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the web_fetch transport-cause change. Prefix compatibility and fallback behavior look correct; three suggestions below (response-body regression coverage, extracting the diagnostic helpers, and aligning cause_chain redaction).

Comment thread crates/zeroclaw-tools/src/web_fetch.rs
Comment thread crates/zeroclaw-tools/src/web_fetch.rs Outdated
Comment thread crates/zeroclaw-tools/src/web_fetch.rs Outdated
@sheperdh
sheperdh merged commit 38fcfaf into memorybox Sep 17, 2026
2 checks passed
@sheperdh
sheperdh deleted the codex/report-web-fetch-causes branch September 17, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants