fixed bugs - #47
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens isolation and sweep execution correctness by adding validation and safer subprocess output handling, with accompanying regression tests.
Changes:
- Add
Sweepinput validation (samples/warmups/params) and make parameter configurations repeatable by snapshotting iterables. - Validate
reporterobjects via a runtime-checkableSweepReporterprotocol before running a sweep. - Limit captured worker stdout/stderr to a bounded tail stored in temp files, and adjust process priority setting to request absolute max Unix priority.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/benchcaddy/core.py |
Validates Sweep inputs early, snapshots params, streams configurations, and validates reporters before running. |
src/benchcaddy/reporting.py |
Marks SweepReporter as @runtime_checkable to support runtime protocol validation. |
src/benchcaddy/isolation/process.py |
Requests absolute max Unix priority via psutil, and bounds worker output capture via temp files + tail reading. |
tests/test_core.py |
Adds coverage for sweep validation, param snapshotting, and reporter validation ordering. |
tests/test_isolation.py |
Adds coverage for absolute Unix priority requests and bounded worker stderr tail behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.