sql: Constant-fold parameterized top-level LIMIT - #37853
Merged
Merged
Conversation
Contributor
Author
|
Ready for review |
Executing a prepared statement with a parameterized LIMIT failed with "Top-level LIMIT must be a constant expression, got integer_to_bigint(3)" whenever the bound parameter type was not bigint, because parameter binding wraps the value in a cast that the bare-literal check did not fold. Evaluate the expression to a literal instead, matching how OFFSET is handled. A negative LIMIT now reports "LIMIT must not be negative" instead of soft-panicking, and a non-constant LIMIT reports "Invalid LIMIT clause: ...". Closes: SQL-476 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ggevay
approved these changes
Aug 4, 2026
ggevay
left a comment
ggevay
left a comment
Contributor
There was a problem hiding this comment.
Nice, thank you!
CI is red because of --auto-index-selects. I'd say it's ok to just exclude that file from --auto-index-selects treatment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing a prepared statement with a parameterized LIMIT failed with "Top-level LIMIT must be a constant expression, got integer_to_bigint(3)" whenever the bound parameter type was not bigint, because parameter binding wraps the value in a cast that the bare-literal check did not fold. Evaluate the expression to a literal instead, matching how OFFSET is handled. A negative LIMIT now reports "LIMIT must not be negative" instead of soft-panicking, and a non-constant LIMIT reports "Invalid LIMIT clause: ...".
Closes: SQL-476