MDEV-40243 Fix MEMORY_LEAK_C leaks in mariadb-dump (rockdb tests)#5418
Open
grooverdan wants to merge 1 commit into
Open
MDEV-40243 Fix MEMORY_LEAK_C leaks in mariadb-dump (rockdb tests)#5418grooverdan wants to merge 1 commit into
grooverdan wants to merge 1 commit into
Conversation
With memory leaks fixed in the rocksdb.mysqldump/mysqldump2 no longer need to run with leak detection disabled. ref: 2217477
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ASAN_OPTIONS="detect_leaks=0" environment variable override from several $MYSQL_DUMP execution commands within the RocksDB test files mysqldump.test and mysqldump2.test. I have no feedback to provide as there are no review comments to evaluate.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
gkodinov
added
the
MariaDB Foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With memory leaks fixed in the rocksdb.mysqldump/mysqldump2 no longer need to run with leak detection disabled.
ref: 2217477