MDEV-40386: DuckDB - pass through compiler and linker flags#5410
Open
grooverdan wants to merge 2 commits into
Open
MDEV-40386: DuckDB - pass through compiler and linker flags#5410grooverdan wants to merge 2 commits into
grooverdan wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CMake configuration for building DuckDB as an external project by forwarding CMAKE_CXX_FLAGS, CMAKE_EXE_LINKER_FLAGS, and CMAKE_MODULE_LINKER_FLAGS. The feedback recommends enclosing the linker flags in double quotes to prevent CMake from splitting space-separated flags into separate arguments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
grooverdan
enabled auto-merge (rebase)
July 20, 2026 07:33
gkodinov
added
the
MariaDB Foundation
Without passing through the compile and linker flags, options like -stdlib=libc++ can create ABI differences between ducksdb extensions and what the server links too. The jemalloc has C files so CMAKE_C_FLAGS is passed through too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.