Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notarytoolhas two auth modes and we were on the one this team can't use: an App Store Connect API key requires a Key ID, which only the Account Holder can mint (and which lives in the.p8's filename, so it can't be recovered from the file). Swapped to the Apple ID mode, which needs only an app-specific password from account.apple.com plus the team id we already read off the signing certificate.Release secrets accordingly:
AC_API_KEY_P8/AC_API_KEY_ID/AC_API_ISSUER_ID→APPLE_ID/APPLE_APP_PASSWORD/APPLE_TEAM_ID. The credentials step no longer writes a key file to$RUNNER_TEMP; the all-three-or-nothing gate, the ad-hoc-signing fallback and the app+dmg stapling are unchanged.The trade-off worth knowing: an app-specific password is tied to a personal Apple ID rather than a team key, so it can't be scoped per-integration — revoking it revokes it everywhere.
Link to Devin session: https://app.devin.ai/sessions/45ed77efb9cd4fe39d69b35ee5c9076f
Open in Devin Desktop: https://app.devin.ai/desktop/session/45ed77efb9cd4fe39d69b35ee5c9076f?variant=devin
Requested by: @MrgSub