Repository navigation
docs: adopt CNC Generals for iOS/macOS name - #3
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates public-facing documentation to adopt “CNC Generals for iOS/macOS” as the fork’s public name, make the direct upstream attribution to ammaarreshi/Generals-Mac-iOS-iPad prominent, and refresh repository links after the rename—without changing any game/engine/build code.
Changes:
- Rename the project in both root READMEs and strengthen upstream attribution language.
- Clarify the “no commercial assets in repo/releases” boundary, while documenting private, personal iOS/iPadOS packaging behavior.
- Update clone/issue/PR links across NOTICE and supporting docs to the renamed repository.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adopt new public name; add prominent upstream attribution; update clone URL; clarify private IPA boundary (CN). |
| README.en.md | Same as above for English README; update clone URL and asset-boundary wording. |
| NOTICE.md | Update notice title/name usage; strengthen lineage wording; update issue-tracker link; add private IPA/app boundary (CN). |
| NOTICE.en.md | Same as above for English notice; update issue-tracker link and private build boundary. |
| docs/WORKDIR/reports/MACOS_LOCAL_FORK_CHANGELOG.md | Update historical PR link to the renamed repository (CN report). |
| docs/WORKDIR/reports/MACOS_LOCAL_FORK_CHANGELOG.en.md | Update historical PR link to the renamed repository (EN report). |
| docs/HOWTO/MACOS_LOCAL_FORK_QUICK_START.md | Update clone/cd commands to the renamed repository (CN how-to). |
| docs/HOWTO/MACOS_LOCAL_FORK_QUICK_START.en.md | Update clone/cd commands to the renamed repository (EN how-to). |
| docs/DEV_BLOG/2026-08-DIARY.md | Add diary entry documenting the public-name adoption and attribution/asset-boundary messaging. |
| docs/BUILD/MACOS.md | Update clone/cd commands to the renamed repository (CN build guide). |
| docs/BUILD/MACOS.en.md | Update clone/cd commands to the renamed repository (EN build guide). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ammaarreshi/Generals-Mac-iOS-iPadattribution prominent in both READMEs and NOTICE filesGeneralsXtechnical identifiers remain for compatibilityWhy
The repository needs a simple public name that distinguishes this personal enhancement fork without presenting it as an independent Apple-platform port or a game mod.
Validation
git diff --checkpassed for all 11 intended document files