Skip to content

docs: adopt CNC Generals for iOS/macOS name - #3

Merged
Log1037 merged 1 commit into
mainfrom
agent/cnc-generals-branding
Aug 10, 2026
Merged

Log1037 merged 1 commit into
mainfrom
agent/cnc-generals-branding

Conversation

@Log1037

@Log1037 Log1037 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

What changed

  • adopt CNC Generals for iOS/macOS as the public fork name
  • make ammaarreshi/Generals-Mac-iOS-iPad attribution prominent in both READMEs and NOTICE files
  • clarify that inherited GeneralsX technical identifiers remain for compatibility
  • document that private iOS/iPadOS builds may embed lawfully owned assets, while asset-bearing IPA/app bundles are never published
  • update clone, issue, and historical PR links after the repository rename

Why

The repository needs a simple public name that distinguishes this personal enhancement fork without presenting it as an independent Apple-platform port or a game mod.

Validation

  • git diff --check passed for all 11 intended document files
  • local Markdown links passed for the primary Chinese and English public documents
  • no game, engine, build, or packaging code changed
  • pre-existing nested reference-repository states were not staged

Copilot AI lite review requested due to automatic review settings August 10, 2026 15:02
@Log1037
Log1037 merged commit 163910d into main Aug 10, 2026
1 check passed
@Log1037
Log1037 deleted the agent/cnc-generals-branding branch August 10, 2026 15:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates public-facing documentation to adopt “CNC Generals for iOS/macOS” as the fork’s public name, make the direct upstream attribution to ammaarreshi/Generals-Mac-iOS-iPad prominent, and refresh repository links after the rename—without changing any game/engine/build code.

Changes:

  • Rename the project in both root READMEs and strengthen upstream attribution language.
  • Clarify the “no commercial assets in repo/releases” boundary, while documenting private, personal iOS/iPadOS packaging behavior.
  • Update clone/issue/PR links across NOTICE and supporting docs to the renamed repository.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Adopt new public name; add prominent upstream attribution; update clone URL; clarify private IPA boundary (CN).
README.en.md Same as above for English README; update clone URL and asset-boundary wording.
NOTICE.md Update notice title/name usage; strengthen lineage wording; update issue-tracker link; add private IPA/app boundary (CN).
NOTICE.en.md Same as above for English notice; update issue-tracker link and private build boundary.
docs/WORKDIR/reports/MACOS_LOCAL_FORK_CHANGELOG.md Update historical PR link to the renamed repository (CN report).
docs/WORKDIR/reports/MACOS_LOCAL_FORK_CHANGELOG.en.md Update historical PR link to the renamed repository (EN report).
docs/HOWTO/MACOS_LOCAL_FORK_QUICK_START.md Update clone/cd commands to the renamed repository (CN how-to).
docs/HOWTO/MACOS_LOCAL_FORK_QUICK_START.en.md Update clone/cd commands to the renamed repository (EN how-to).
docs/DEV_BLOG/2026-08-DIARY.md Add diary entry documenting the public-name adoption and attribution/asset-boundary messaging.
docs/BUILD/MACOS.md Update clone/cd commands to the renamed repository (CN build guide).
docs/BUILD/MACOS.en.md Update clone/cd commands to the renamed repository (EN build guide).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants