Skip to content

feat(TeamParticipants): store role data to LPDB - #8016

Open
ElectricalBoy wants to merge 3 commits into
mainfrom
team-participant-store-role
Open

feat(TeamParticipants): store role data to LPDB#8016
ElectricalBoy wants to merge 3 commits into
mainfrom
team-participant-store-role

Conversation

@ElectricalBoy

Copy link
Copy Markdown
Collaborator

Summary

This PR adds support for storing player roles to placement.opponentplayers from TeamParticipants.

How did you test this change?

preview with dev

@hjpalpha

Copy link
Copy Markdown
Collaborator
  • why is this needed/wanted
  • could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

@ElectricalBoy

ElectricalBoy commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

why is this needed/wanted

#8017 depends on this

could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB?
Might just need to throw role info to placement.extradata if there is a limit 🤷

@hjpalpha

Copy link
Copy Markdown
Collaborator

why is this needed/wanted

#8017 depends on this

could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?

placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB? Might just need to throw role info to placement.extradata if there is a limit 🤷

if it has a length limit, it is a pretty big one
the question was about edge cases with e.g. >20 players per team opponent anyways

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants