You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?
placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB?
Might just need to throw role info to placement.extradata if there is a limit 🤷
could we get length limit issues of the opponentplayers field due to this for cases where there are many players per opponent?
placement.opponentplayers doesn't seem to have a length limit specified according to Special:LiquipediaDB? Might just need to throw role info to placement.extradata if there is a limit 🤷
if it has a length limit, it is a pretty big one
the question was about edge cases with e.g. >20 players per team opponent anyways
The reason will be displayed to describe this comment to others. Learn more.
code wise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for storing player roles to
placement.opponentplayersfromTeamParticipants.How did you test this change?
preview with dev