Skip to content

refactor: ThisDay to widget3 - #8013

Open
ElectricalBoy wants to merge 10 commits into
mainfrom
thisday-widget3
Open

refactor: ThisDay to widget3#8013
ElectricalBoy wants to merge 10 commits into
mainfrom
thisday-widget3

Conversation

@ElectricalBoy

@ElectricalBoy ElectricalBoy commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Part of #7742

This PR:

  • replaces custom tournament display code with Module:Widget/Tournament/Title
  • moves tiny bits of data processing code out of widget modules
  • migrates thisday display to widget3

How did you test this change?

preview with dev

@ElectricalBoy
ElectricalBoy requested review from a team August 27, 2026 03:14
@ElectricalBoy ElectricalBoy self-assigned this Aug 27, 2026
@ElectricalBoy
ElectricalBoy marked this pull request as ready for review August 27, 2026 03:23

@hjpalpha hjpalpha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe convert to structure mentioned in rfc too?

Comment thread lua/wikis/commons/ThisDay/Query.lua Outdated
@ElectricalBoy

Copy link
Copy Markdown
Collaborator Author

maybe convert to structure mentioned in rfc too?

maybe in a stacked pr; not in this one for sure

@ElectricalBoy
ElectricalBoy requested a review from hjpalpha August 27, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants