Repository navigation
Route torrents through SOCKS5 proxies - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Torrents no longer unconditionally bypass the proxy.
ResolvedProxy::torrent_socks_url: SOCKS5 only (socks5h normalizes to socks5); HTTP(S) proxies stay direct.plan_torrent_net(pure, tested): under SOCKS, DHT off, listen port 0, UDP trackers dropped — the engine cannot proxy any of those, so they go dark instead of leaking. Invalid manual proxy fails the row loudly like every other engine.connect.proxy_urlset at creation (same creation-scoped rule as DHT/listener: edits apply to new sessions).CONFLICT NOTE: #74 touches the same subtitle line — merge in order (#74 first) or close #74 in favor of this.
239 passing (5 new), clippy/fmt clean. No live-torrent test possible (no seed harness); peer path verified against librqbit 9.0.1 sources (validate() on both add paths, no local DNS on peer path, reqwest-proxied HTTP trackers).