Repository navigation
Harden staging/cookies/labels; indeterminate resolve on every spawn - #73
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, both from the whole-state review:
Batch 2 hardening:
duration_stringin the Pango-markup group description (Escape Pango markup in video preview header #65 missed it).create_new+0o600from birth); pre-planted symlinks fail instead of diverting the dump.ensure_staging_dirhelper: create + canonicalize + verify-under-root at both staging call sites;clean_stagingguard canonicalized too. 2 new tests (roundtrip, symlink-escape rejection).Indeterminate everywhere (follow-up to #72):
236 passing, clippy/fmt clean.