Skip to content

Show Install when media tools are missing - #496

Closed
Linuxuser67 wants to merge 3 commits into
mainfrom
fix/fresh-install-tool-state
Closed

Linuxuser67 wants to merge 3 commits into
mainfrom
fix/fresh-install-tool-state

Conversation

@Linuxuser67

Copy link
Copy Markdown
Owner

Summary

Fix the misleading “Couldn't check for updates” state on fresh or data-cleared Flatpak installs.

  • Probe only for the presence of the required yt-dlp/ffmpeg binaries when the Media preferences page opens. Show a temporary disabled “Checking installed tools…” state instead of exposing “Check for Updates” before their presence is known.
  • Show Install when the required binaries are missing.
  • If the tools disappear between the presence probe and a button click, short-circuit the update flow to Install rather than querying upstream releases and falling through to the generic update-check error.
  • Keep version probes and upstream release checks on-demand; this does not introduce automatic update checks on page open.

Validation

  • Confirmed the failure path: a missing core binary makes resolve_libraries() return None, but the old handler still fetched release metadata and then marked the result indeterminate.
  • CI will run formatting, Clippy, Rust tests, UI tests, dependency/vendor consistency, structure, and audit checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant