Repository navigation
Pad grid checker cells on both axes - #478
Merged
Merged
Conversation
GridView has no row/column spacing properties; the cell box margins are the only separation. 2px vertical and none horizontal made themed chips touch between rows.
Linuxuser67
pushed a commit
that referenced
this pull request
Oct 19, 2026
#478 used 4px vertical and 6px horizontal margins, giving 8px row gaps and 12px column gaps — unequal and off the 6px GNOME rhythm. One uniform 3px on all sides yields 6px between cells on both axes.
Linuxuser67
added a commit
that referenced
this pull request
Oct 19, 2026
* Revert "Pad grid picker cells on both axes (#478)" This reverts commit 10e984a. * Uniform 3px grid-cell margins #478 used 4px vertical and 6px horizontal margins, giving 8px row gaps and 12px column gaps — unequal and off the 6px GNOME rhythm. One uniform 3px on all sides yields 6px between cells on both axes. * Grid cell gaps in CSS on the item node The chip is the theme's painting of the gridview > child node, which spans the whole cell, and GtkListItem is not a widget — margins can't be set from Rust at all. Inner-box margins (beta.16 report) only inset content inside the chip. Ship a small app stylesheet rule instead: gridview > child { margin: 3px } on the same node, loaded once per display. 3px = 6px gap between cells on both axes, the GNOME rhythm. --------- Co-authored-by: houssemko <houssemko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screenshot report: themed chips of the recycling-grid picker cells touch between rows.
GridViewhas no row/column-spacing properties, so separation comes from the factory cell box's margins — 2px top/bottom, none horizontally. Bumped to 4/4 vertical and 6/6 horizontal. Affects all three picker surfaces (playlist, torrent, gallery) through the one shared factory.