Repository navigation
Audit cuts: drop gallery.rs facade, single dotted-version parser - #476
Merged
Merged
Conversation
…rser The gallery.rs facade re-exported five gallery_tools symbols; retarget the call sites directly. Drop the strict parse_yt_dlp_version / ytdlp_update_available pair, which the tolerant parse_dotted_version / tool_update_available already subsumes (it strips v/n prefixes and pads missing parts); carry the old matrix's distinctive cases into the tolerant tests.
Linuxuser67
force-pushed
the
feature/facade-cuts
branch
from
October 19, 2026 09:50
ff7d745 to
ca99e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two cuts from the ponytail-audit (/ponytail-audit) — net −39 lines, 0 deps:
gallery.rsfacade. It only re-exported fivegallery_toolssymbols (plus a stale "phase 4" note). All call sites inpreferences.rsandinstall_progress.rsnow point atcrate::gallery_tools::*directly.video.rsanddownload.rsfacades stay: they're the house pattern for cluster modules (parent re-exports feed the big#[path]-attached test files'use super::*), so cutting them rewrites 154 call sites + two 8–10k-line test headers for the same line count — not a cut.parse_yt_dlp_version+ytdlp_update_availablespecial-cased what the tolerantparse_dotted_version+tool_update_availablealready handle: it stripsv/nprefixes and pads missing parts (8.0→[8,0,0]), and real yt-dlp output (2026.08.19, tags,nightly) parses identically under both. Deleted the strict pair, retargeted its three call sites (including theMIN_YTDLP_VERSIONfloor check), and carried the old matrix's distinctive cases into the tolerant tests (2025.01.01\n,2026.08→[2026,8,0],not.a.version→None), so parsing behavior stays fully pinned.