Repository navigation
Gallery runner: cap its stderr drain with the shared per-line reader (missed #472 merge) - #475
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of the review follow-up from
feature/gallery-followups(1ea2799), which was created after #472 was merged at21ebbf5— so it never reached main.What
gallery_runner.rs) now reads through the sharedread_capped_line/MAX_JSONL_LINE_BYTES(madepub(crate)ingallery_probe.rs), same loop shape as the probe'sspawn_stderr_tail: over-cap or error stops tail updates instead of letting one hostile multi-MiB stderr line inflate the diagnostic ring.echo_line, the 20-line ring and all failure-tail semantics are unchanged; only the per-line ceiling is added.This was the single REQUIRED item from the independent #472 review; the rest of that verdict was verified there.