ci(desktop): fix Windows long-path and Linux Vulkan SPIRV-Headers build breaks#61
Closed
MegalithOfficial wants to merge 1 commit into
Closed
ci(desktop): fix Windows long-path and Linux Vulkan SPIRV-Headers build breaks#61MegalithOfficial wants to merge 1 commit into
MegalithOfficial wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Desktop CI (run 27508104374) broke after the llama.cpp submodule bump to
b9611-3(ebc10770a). Two independent build-infra failures, neither in the wrappers:cargocould not check out the git dependency: new llama.cpp shipstools/ui/(llama-server Svelte WebUI, ~599 files, 161-char paths) which exceeds Windows' 260-charMAX_PATHunder.cargo/git/checkouts/.... libgit2 errorclass=Filesystem (30).ggml/src/ggml-vulkan/CMakeLists.txt:14onfind_package(SPIRV-Headers CONFIG REQUIRED)(upstream PR #22009); CI never provided SPIRV-Headers.Changes (both
desktop-build.ymlanddesktop-release-build.yml)CARGO_NET_GIT_FETCH_WITH_CLI: "true"+ an "Enable Windows long paths" step (git config --system core.longpaths true+LongPathsEnabledregistry key) so cargo fetches with system git and long paths work.spirv-headersapt package (cmake config lands under/usr, already on CMake's search path).Windows Vulkan needs only the path fix — the LunarG SDK ships SPIRV-Headers' cmake config and the job exports
VULKAN_SDK.