Migrate GraphViewer to modern expressions and portable plot geometry - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GraphViewer previously retained mutable Surface/GDI+ paths and coupled formula evaluation to drawing. This migration uses bound unary expressions, explicit plot definitions and snapshots, and portable geometry from MathExpression 1.1.0 and FunctionPlotting 1.2.0.
Validation: the application owner built and tested the application. The final local package pass compiled all three modern Windows targets. The Windows workflow builds net35/net40 with the full resource toolchain and exercises native drawing, all five encoders, margins, overlays and form resize against the pinned producer packages.
Producer dependency: Library PR #3. Build Library into the shared local NuGet feed first. See docs/graphviewer-migration.md for numerical semantics and manual printer/DPI review notes. FreeBSD work remains deferred.