Migrate netexpr to the modern expression API - #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netexpr used the legacy parser and LINQ-expression compilation. This migration uses MathParser, MathBinder and interpreted evaluation from LTRData.MathExpression 1.1.0, with source diagnostics and explicit variable binding.
Preserve formula argument joining, invariant numeric output, case-insensitive prompted assignments and the historical rounded numeric exit code. Handle missing input and non-finite results explicitly. Modern power precedence applies; shift/bitwise syntax is intentionally rejected. Keep all five existing targets, including net35/net40.
Validation: the application owner tested the migration. The final package build compiled every target and the 13 command-line scenarios passed. The focused workflow has also passed on Linux and Windows, building the pinned Library revision through a fresh shared NuGet feed.
Producer dependency: Library PR #3. Build its packages first; this repository continues to consume NuGet packages across repository boundaries. See docs/netexpr-migration.md for behavior and review commands.