Sharded dataset generation - #73
Conversation
2ad7850 to
a6697cf
Compare
michaelmckinsey1
left a comment
There was a problem hiding this comment.
I don't understand when unsharded "V2" datasets would be used? When would those be used? When under scale 11?
In general I think we should discuss the use of keeping around V1 and V2 support. Is it even feasible to fully migrate to V3 and deprecate?
@michaelmckinsey1 I figured leaving V2 support in would be good so we can reuse existing datasets. It does add complexity though, so I'm happy to remove it if you're cool with regenerating datasets for existing problem configs. I suppose since we already have good data up to scale 10, there won't be much opportunity to reuse existing V2 datasets anyway... |
I am ok with regenerating them if it reduces complexity. |
a9dcd6e to
cb95d05
Compare
… sharding matches distconv spec
cb95d05 to
1cf9412
Compare
Summary
Adds v3 physical sharded dataset generation and loading, with shard files written to match the configured DistConv layout. This lets large samples be generated directly as per-rank physical shards instead of always writing full-volume samples, and should allow us to generate scale 11 data.
Changes
dc_num_shards/dc_shard_dimspairs reuse the same dataset cache.Validation
1x1x1,1x1x2,1x2x2, and1x1x4; all 18 pairwise comparisons passed.