Walk up for blueprints when discovering suites in CI - #250
Merged
Conversation
The discover step only looked in a spec's own directory, so at-rules and pattern-css never ran in CI: both inherit tests/blueprint.json. Only the release workflow ran them, which is why a broken at-rules test surfaced during a release instead of on the PR that caused it. playwright.config.ts already walks up. The two now agree. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's discover step only looked in a spec's own directory, so
at-rulesandpattern-cssnever ran — both inherittests/blueprint.json. Onlymanual-overridehas one in its own folder, so it was the only suite CI ever executed.Those specs still ran during a release, which is how a broken at-rules test blocked 1.5.7 instead of failing on the PR that introduced it.
playwright.config.tsalready walks up. This makes the workflows agree, for both the regular and nightly runs.🤖 Generated with Claude Code