Scope the at-rules assertions to the block's own style - #249
Merged
Conversation
The test read the whole page, so any @font-face or @Keyframes from the theme or core failed it. WordPress trunk ships one, which is why this only broke on nightly. The plugin strips both from the CSS it emits, and that style tag is all the test should have been reading. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The at-rules spec read
page.content()— the whole document — so any@font-faceor@keyframesshipped by the theme or core failed it. WordPress trunk ships one, which is why this only broke on nightly and blocked the 1.5.7 release.The plugin strips both from the CSS it emits, and that
<style id="pcss-block-*">is all the test should have been reading.The 1.5.7 release and tag were deleted; the version metadata is still on main, so it can be re-cut once this lands.
🤖 Generated with Claude Code