Repository navigation
Conversation
PY44N
force-pushed
the
fix/compound-serde-cfg-gate
branch
from
September 6, 2026 17:32
8bc8429 to
96a3984
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compound.rs unconditionally use serde::{Deserialize, Serialize}, unlike the other AST modules (mod.rs, lua52.rs, lua54.rs, span.rs, punctuated.rs), which all gate that import behind #[cfg(feature = "serde")]. Since serde is an optional dependency, this broke:
with error[E0432]: unresolved import 'serde'.