Skip to content

Support LegendHDF5IO 0.2 #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
oschulz wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support LegendHDF5IO 0.2 #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions ext/SolidStateDetectorsLegendHDF5IOExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,24 @@ function SolidStateDetectors.simulate_waveforms( mcevents::AbstractVector{<:Name
end


# Add support for reading and writing CartesianPoint and CylindricalPoint using LegendHDF5IO
function __init__()
LegendHDF5IO._datatype_dict["cartesianpoint"] = CartesianPoint
LegendHDF5IO._datatype_dict["cylindricalpoint"] = CylindricalPoint
# Add support for reading and writing CartesianPoint and CylindricalPoint using LegendHDF5IO.
# LegendHDF5IO v0.2 registers datatype names with `register_datatype!`, v0.1 through its
# datatype dictionary and `datatype_to_string`:
if isdefined(LegendHDF5IO, :register_datatype!)
function __init__()
LegendHDF5IO.register_datatype!("cartesianpoint", CartesianPoint)
LegendHDF5IO.register_datatype!("cylindricalpoint", CylindricalPoint)
end
else
function __init__()
LegendHDF5IO._datatype_dict["cartesianpoint"] = CartesianPoint
LegendHDF5IO._datatype_dict["cylindricalpoint"] = CylindricalPoint
end

LegendHDF5IO.datatype_to_string(::Type{<:CartesianPoint}) = "cartesianpoint"
LegendHDF5IO.datatype_to_string(::Type{<:CylindricalPoint}) = "cylindricalpoint"
end

LegendHDF5IO.datatype_to_string(::Type{<:CartesianPoint}) = "cartesianpoint"
LegendHDF5IO.datatype_to_string(::Type{<:CylindricalPoint}) = "cylindricalpoint"



# support writing points to HDF5 file using LH5Array
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
[compat]
Geant4 = "0.3.1"
LegendDataTypes = "0.1.3"
LegendHDF5IO = "0.1"
LegendHDF5IO = "0.1, 0.2"
Loading