Repository navigation
[20.0][MIG] sale_tier_validation: Migration to 20.0 - #3
Merged
Merged
Conversation
Available types: 'task#', 't#' (case insensitive) Examples:
|
alan196
force-pushed
the
20.0-mig-sale_tier_validation
branch
from
October 10, 2026 14:31
12d4a38 to
719490e
Compare
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/zh_CN/
Currently translated at 100.0% (13 of 13 strings) Translation: sale-workflow-13.0/sale-workflow-13.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_tier_validation/
Currently translated at 100.0% (19 of 19 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/
Currently translated at 100.0% (20 of 20 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_tier_validation/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/es/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/it/
Currently translated at 100.0% (22 of 22 strings) Translation: sale-workflow-17.0/sale-workflow-17.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_tier_validation/sv/
Currently translated at 100.0% (28 of 28 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_tier_validation/nl/
Currently translated at 100.0% (28 of 28 strings) Translation: sale-workflow-18.0/sale-workflow-18.0-sale_tier_validation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_tier_validation/ja/
…pending or rejected
Assisted-by: Claude Fable 5.1
- Add ruff RUF012 noqa on the mutable class attributes (_inherit, _state_from, _state_to), as done in base_tier_validation. - Tests: BaseCommon now runs each test as a dedicated test user instead of the superuser, so declare _test_user_groups (sales manager + system, the test confirms orders and toggles the company print-block setting). Without it the tests fail with AccessError on sale.order. - No other functional change needed: the sale.order form buttons, search filters, settings block and report template extended by the module still exist in 20.0. Assisted-by: Claude Fable 5.1
alan196
force-pushed
the
20.0-mig-sale_tier_validation
branch
from
October 10, 2026 15:13
719490e to
5399a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
sale_tier_validationto 20.0.Depends on #1 (
base_tier_validation, mirror of OCA#94). This branch is rebased on top of that one, so the first commits belong to that PR; do not merge before it.Changes
oca-portfrom 19.0.__manifest__.py: version20.0.1.0.0.RUF012noqa on the mutable class attributes (_inherit,_state_from,_state_to), same pattern asbase_tier_validation.BaseCommonin 20.0 runs every test as a dedicated test user instead of the superuser, so the test class declares_test_user_groups = ("base.group_system", "sales_team.group_sale_manager")(the test confirms orders and toggles the company-level print block). Without it the tests fail withAccessErroronsale.order.idbeforemodelin a record), regenerated README.action_confirmbuttons,my_sale_orders_filter, theproforma_configurationsetting and thesale.report_saleordertemplate extended by the module still exist in 20.0.How it was tested
Fresh database with demo data on Odoo 20.0,
-i sale_tier_validation --test-enable --test-tags /sale_tier_validation:0 failed, 0 error(s), no ERROR/CRITICAL lines or tracebacks, no deprecation warnings.odoo-bin shellwith real users (salesperson + reviewer): confirmation blocked before validation,request_validationleaves the order pending for the reviewer only, reviewer validates and the salesperson confirms (state = sale), a rejected order cannot be confirmed, the print block raises when enabled, and the reviewer's systray counter shows the pending review. Messages render the Material icons (oi).Assisted-by: Claude Fable 5.1