Repository navigation
19.0 mig product secondary unit - #3
Merged
Merged
Conversation
![Olar Alca [Vauxoo]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
* New Field Added to store the URL of the product on the manufacturer page. * Added field manufacturer product URL to the product view. * README updated.
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
Add # -*- encoding: utf-8 -*-
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-13.0/product-attribute-13.0-product_manufacturer Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_manufacturer/pt_BR/
Currently translated at 100.0% (5 of 5 strings) Translation: product-attribute-14.0/product-attribute-14.0-product_manufacturer Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_manufacturer/nl/
…uct variant not visible enable manufacturer visibility
The field `secondary_uom_qty` is defined in the mixin class `product.secondary.unit.mixin` as being computed, but without precomputation. This makes that when this field is used in the variable `_secondary_unit_fields` for classes using the mixing, it ends up as a dependency of other fields that are computed and do require precomputation. But, not being the field `secondary_uom_qty` precomputed, it disables the precomputation of those other fields. This has an impact when installing the module `sale` along with the module `product_secondary_unit`, which causes the module `sale_order_secondary_unit` to be auto-installed. As a result, the following errors appear in the log, disabling the precomputation of 11 other fields: ```text /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.product_uom_qty cannot be precomputed as it depends on non-precomputed field sale.order.line.secondary_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_unit cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.discount cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_reduce cannot be precomputed as it depends on non-precomputed field sale.order.line.price_unit /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_subtotal cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_tax cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_total cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_reduce_taxexcl cannot be precomputed as it depends on non-precomputed field sale.order.line.price_subtotal /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.price_reduce_taxinc cannot be precomputed as it depends on non-precomputed field sale.order.line.price_total /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.product_packaging_id cannot be precomputed as it depends on non-precomputed field sale.order.line.product_uom_qty /opt/project/repos/odoo/odoo/fields.py:802: UserWarning: Field sale.order.line.product_packaging_qty cannot be precomputed as it depends on non-precomputed field sale.order.line.product_packaging_id ``` Making `secondary_uom_qty` precomputed solves these warnings.
Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/hr/
Currently translated at 95.6% (22 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/tr/
Currently translated at 100.0% (23 of 23 strings) Translation: product-attribute-18.0/product-attribute-18.0-product_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/product-attribute-18-0/product-attribute-18-0-product_secondary_unit/ja/
Replace _get_factor_line() with uom._compute_quantity() to fix incorrect conversion when line UoM differs from product's base UoM. The previous method failed for certain UoM combinations (e.g., line in L, product in mL). Co-authored-by: Yoshi Tashiro <tashiro@quartile.co>
Available types: 'task#', 't#' (case insensitive) Examples:
|
HectorMerazChavez
force-pushed
the
19.0-mig-product_secondary_unit
branch
from
February 18, 2026 19:40
0e4f260 to
e243447
Compare
Available types: 'task#', 't#' (case insensitive) Examples:
|
Available types: 'task#', 't#' (case insensitive) Examples:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.