fix: compare alpha channel in MSE::operator==#666
Open
for13to1 wants to merge 1 commit into
Open
Conversation
The alpha channel comparison was comparing this->a with itself instead of other.a, causing MSE equality to ignore alpha differences.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the comparison bug in the
MSEequality operator where the alpha channel was compared to itself instead of the target object.Changes
MSE::operator==typo: Correctedstd::tie(other.r, other.g, other.b, a)tostd::tie(other.r, other.g, other.b, other.a)inConversionDifferenceRGB.h.calculateDifferenceAndMSEdoes not calculate MSE for the alpha channel (which is expected by design since the difference tool only targets RGB color components), fixing the typo would otherwise break unit tests with alpha components (such asRGBA_8bitetc.).Adjusted
ConversionDifferenceRGBTest.cppto explicitly ignore alpha channel differences (diff.a = 0) before adding samples. This ensures the test's expected MSE aligns with the library's actual calculations.Verification
Ran all unit tests on macOS:
All 1860 tests now pass successfully (100% PASSED).