build: add workflow for github pages#827
Conversation
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
Overall this looks pretty good, but the deployed pages still doesn't look 100% correct. I see some markdown elements rendered there: https://ibm.github.io/openapi-validator/docs/ibm-cloud-rules.html
Can we fix it somehow?
There was a problem hiding this comment.
I think this file should be in the project root as that's the source directory for Jekyll in the GH Action workflow.
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
pyrooka
left a comment
pyrooka
left a comment
There was a problem hiding this comment.
Few comments to address, otherwise it looks good. I like the result a lot!
| @@ -0,0 +1,51 @@ | |||
| # Sample workflow for building and deploying a Jekyll site to GitHub Pages | |||
There was a problem hiding this comment.
This line should be removed I think. It's not just a sample anymore. :)
| id-token: write | ||
|
|
||
| # Allow only one concurrent deployment, skipping runs queued between the run in-progress and latest queued. | ||
| # However, do NOT cancel in-progress runs as we want to allow these production deployments to complete. |
There was a problem hiding this comment.
Since cancel-in-progress is set to true this comment contradicts with the actual config, right?
| > [!CAUTION] | ||
| > Disabling certain rules may lead to false negatives for problems identified by other rules. | ||
| > **Caution:** Disabling certain rules may lead to false negatives for problems identified by other rules. |
There was a problem hiding this comment.
Visually the older version is better, but I guess it's necessary to change this for Jekyll, right?
There was a problem hiding this comment.
It was an issue in the beginning making the table under it break, but since then i fixed most of the broken html parsing in the markdown file. I can check how it renders now and change it back if it doesn't break it.
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
…dator into lt/github-pages
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
|
🎉 This PR is included in version 1.37.17 🎉 The release is available on Your semantic-release bot 📦🚀 |
3 participants
Add github pages configuration through Github Actions.