Add Prebid error diagnostics#893
Merged
Merged
Conversation
ChristianPavilonis
force-pushed
the
add-prebid-error-diagnostics
branch
from
July 14, 2026 15:45
1f2946f to
62a2dd0
Compare
Collaborator
Author
ChristianPavilonis
marked this pull request as ready for review
July 14, 2026 16:05
ChristianPavilonis
requested review from
aram356 and
prk-Jr
and removed request for
aram356
July 14, 2026 16:07
This was referenced Jul 14, 2026
ChristianPavilonis
changed the base branch from
main
to
issue-858-ssat-compression-offload
July 15, 2026 15:20
ChristianPavilonis
changed the base branch from
issue-858-ssat-compression-offload
to
feat/ssat-write-prebid-response-debug
July 15, 2026 15:21
aram356
requested changes
Jul 15, 2026
aram356
left a comment
Collaborator
There was a problem hiding this comment.
Summary
The diagnostics are carefully debug-gated, sanitized, bounded, and correlated with escaped auction IDs. One correctness gap still allows oversized non-2xx bodies to bypass the new HTTP-status classification, so changes are requested.
Blocking
🔧 wrench
- Preserve HTTP classification for oversized error bodies (
crates/trusted-server-core/src/integrations/prebid.rs:1977): body collection can fail before the known non-2xx status is converted into provider metadata.
Non-blocking
🏕 camp site
- Add a public
/auctionresponse-shape regression (crates/trusted-server-core/src/integrations/prebid.rs:5135): exercise the security contract through final response serialization.
CI Status
- GitHub integration artifact preparation: PASS
- GitHub integration tests: PASS
- GitHub Fastly EC lifecycle tests: PASS
- GitHub browser integration tests: PASS
- Targeted native Prebid tests: PASS (163 tests)
- Axum tests: PASS (12 tests)
- fmt: PASS
- Local Fastly runtime: BLOCKED by unavailable macOS certificate keychain after successful compilation
- Local clippy-fastly: BLOCKED by local build-tool invocation error (
Unrecognized option: 'p')
aram356
approved these changes
Jul 15, 2026
aram356
left a comment
Collaborator
There was a problem hiding this comment.
Summary
The follow-up commit resolves the prior blocking issue: non-2xx HTTP classification now survives oversized or unreadable response bodies, with one-shot and streaming regressions. The public /auction response also has explicit debug-gating, normalization, and truncation coverage. No additional findings remain.
CI Status
- GitHub integration artifact preparation: PASS
- GitHub integration tests: PASS
- GitHub Fastly EC lifecycle tests: PASS
- GitHub browser integration tests: PASS
- Targeted native Prebid tests: PASS (166 tests)
- fmt: PASS
- Fastly
wasm32-wasip1compilation: PASS
Collaborator
|
@ChristianPavilonis please resolve conflicts |
4 tasks
ChristianPavilonis
force-pushed
the
add-prebid-error-diagnostics
branch
2 times, most recently
from
July 17, 2026 16:44
c3143ab to
4ca09fa
Compare
ChristianPavilonis
changed the base branch from
feat/ssat-write-prebid-response-debug
to
main
July 17, 2026 16:46
Prebid non-2xx responses were reduced to bare provider errors, making intermittent failures difficult to diagnose. Surface safe HTTP metadata and bounded debug details while correlating server logs with the auction ID.
ChristianPavilonis
force-pushed
the
add-prebid-error-diagnostics
branch
from
July 17, 2026 16:47
4ca09fa to
7af7598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-core/src/integrations/prebid.rsdocs/guide/integrations/prebid.mdCloses
Closes #909.
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest run(JS unchanged)cd crates/trusted-server-js/lib && npm run format(JS unchanged)cd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-cloudflare,cargo test-spin, Cloudflare/Spin native and WASM clippy aliases, and integration parity tests.Checklist
unwrap()in production code — useexpect("should ...")logmacros (notprintln!), perCLAUDE.md