Repository navigation
refactor: harden protocol, actors, WAL, and plugins - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
本分支针对服务端代码质量、Actor 并发一致性、WAL 恢复语义、插件运行时安全,以及与官方
phira-mp客户端的协议兼容性进行了修复和重构。主要问题包括:房间成员状态同时存在于 Actor 和连接注册表、加入/断开/踢出路径可能留下 Ghost member、WAL 对损坏尾帧过度宽容、插件默认权限过高,以及服务端
Message::Played扩展字段与官方 v1 客户端协议不一致。主要改动
协议与传输
Message::Played的四字段布局,详细判定统计保留在服务端记录和插件事件中。Room Actor 与成员一致性
AddUser将连接引用带入 Actor 命令,在同一串行操作中完成连接注册和权威成员提交。user.room完成绑定,避免取消时留下 Ghost member。WAL 与持久化
插件系统与 ABI
admin、room.manage、HTTP、TCP、文件、加密等权限必须由 sidecar 显式授予。timercapability 校验。phira-plugin-v3/abi-wit-v3。兼容性与风险
cfg(any())守卫影响,预编译 fixture 尚未重新生成;ABI 合约和生命周期基础测试仍通过。验证
cargo check --workspace --all-featurescargo clippy --workspace --all-features --all-targets -- -D warningscargo test --workspace --all-features完整测试套件在首轮实现提交上通过;review 修复后重新运行了编译检查及协议、WAL、房间和能力相关回归测试。