Conversation
…e closed before the submenu click could be registered. Also ignores package-lock.json.
Deploying with
|
| Latest commit: |
a264d14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb9f4ac7.graphite-master.pages.dev |
Keavon
approved these changes
Aug 10, 2021
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Fix a bug where clicking a submenu would cause the parent menu to be closed before the submenu click could be registered. Also ignores package-lock.json. * Remove package-lock gitignore * Add back empty line
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
* Fix a bug where clicking a submenu would cause the parent menu to be closed before the submenu click could be registered. Also ignores package-lock.json. * Remove package-lock gitignore * Add back empty line
Member
|
Hi @KeatonTech, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the parent menu would close on MouseDown, before the Click event could trigger on submenu items. This fix involves ensuring that the parent menu stays open as long as the cursor remains on any of its sub-menus.
Fixes #280
This change is