New node: Solidify Stroke

[Kakapio]

This node can be added after a stroke node in a set of vector data. Upon doing so, it will account for the stroke's shape and add it to the vector data. The stroke will be treated as a solid part of the shape or line segment. Both closed shapes and line segments are supported.

Closes #1092

[Keavon]

Welcome, thanks for the contribution!

It looks like this does not currently compile.

[Kakapio]

Welcome, thanks for the contribution!

It looks like this does not currently compile.

Sorry, had a missing import. Should compile now.

[Keavon]

!build

[github-actions]

📦 Build Complete for 7acb608
https://4c3f345c.graphite.pages.dev

[Kakapio]

I think I have noticed an issue where even for a closed vector shape the node assumes it's an open shape and uses the wrong vectordata....looking into this. One of my local files didn't have this issue, but new ones do. Strange.

[Kakapio]

resolved an issue. fully functional now. please rebuild.

[otdavies]

!build

[github-actions]

📦 Build Complete for 1a74ff6
https://3457cc2d.graphite.pages.dev

[Keavon]

!build

[github-actions]

📦 Build Complete for 52e7224
https://b573b226.graphite.pages.dev

[Keavon]

Can you please rename this to "Solidify Stroke"?

Also, the stroke width doesn't seem to be the same. Is it perhaps being doubled (diameter being treated as radius)?

[otdavies]

!build

[github-actions]

📦 Build Complete for 17ba1ba
https://2e18b657.graphite.pages.dev

[Keavon]

!build

[github-actions]

📦 Build Complete for 7eac88e
https://069a2d94.graphite.pages.dev

[Keavon]

There's one bug I found, but I'm not sure if it's caused by your code: a layer with a shape and a non-1x1 transform, when you have it selected and switch to the Path tool, changes in size to gain a 1x1 transform. I'm probably just going to merge this anyways and we can work on a followup fix.

@0HyperCube do you know if that's a general bug or if that's because this node is doing (or not doing) something special?

[Keavon]

Hi @Kakapio, thanks again for this code contribution to the project! We're still hoping you will respond to the request to relicense this code. Please see #4208 ASAP, thank you!