Skip to content

feat: add default_follower_role to feed group API - #342

Merged
JimmyPettersson85 merged 1 commit into
mainfrom
feature/feeds-1843-default-follower-role-per-group
Sep 1, 2026
Merged

feat: add default_follower_role to feed group API#342
JimmyPettersson85 merged 1 commit into
mainfrom
feature/feeds-1843-default-follower-role-per-group

Conversation

@JimmyPettersson85

Copy link
Copy Markdown
Contributor

Summary

Regenerated src/gen from the chat OpenAPI spec on the matching chat branch feature/feeds-1843-default-follower-role-per-group (FEEDS-1843), which adds a configurable default follower role per feed group.

default_follower_role seeds follower_role on new follows of feeds in a group, so an app can have e.g. a premium group whose followers default to feed_member_viewer (read, react, vote; no commenting) without a webhook round-trip and the permission window it leaves open.

Surface:

model shape
CreateFeedGroupRequest default_follower_role?: string
UpdateFeedGroupRequest default_follower_role?: string
GetOrCreateFeedGroupRequest default_follower_role?: string
FeedGroupResponse default_follower_role?: string
FeedGroup default_follower_role: string (required, matching the adjacent default_visibility)

Why this branch exists now

tests/qa/Makefile in the chat repo probes this repo for a branch whose name matches the chat branch and swaps @stream-io/node-sdk to it, falling back to main. The chat PR's QA tests use the typed default_follower_role field, so they need this branch to resolve. Verified locally:

ℹ️  Swapped @stream-io/node-sdk: npm 0.8.3 → git branch 'feature/feeds-1843-default-follower-role-per-group' (0.8.3)
Test Files  3 passed (3)
     Tests  237 passed (237)

Notes for review

src/gen is regenerated wholesale, so this diff is not limited to the field above. It also carries chat API surface merged since v0.8.3 that has not been released yet:

  • ReminderResponseDataCreateReminderResponse (rename + new decoder)
  • member_custom_on_mentioned_users_enabled
  • mentioned_channel_members
  • create_users
  • privacy_settings, teams_role, filter_conditions, and related fields

That is inherent to regenerating the client and is what the post-release SDK regeneration would produce anyway — but it does mean approving this approves more than FEEDS-1843. Worth sequencing against the chat release if that matters.

No hand-edits: every file under src/gen is generator output (./generate-openapi.sh), followed by the repo's own yarn lint:gen.

🤖 Generated with Claude Code

Regenerated from the chat OpenAPI spec on branch
feature/feeds-1843-default-follower-role-per-group (FEEDS-1843), which adds a
configurable default follower role per feed group.

default_follower_role appears as an optional field on CreateFeedGroupRequest,
UpdateFeedGroupRequest, GetOrCreateFeedGroupRequest and FeedGroupResponse, and
as a required field on FeedGroup alongside the existing default_visibility.

This branch exists so the chat repo's QA suite resolves against it: tests/qa's
yarn-install probes stream-node for a branch matching the chat branch name and
swaps @stream-io/node-sdk to it, falling back to main.

Note: src/gen is regenerated wholesale, so this also picks up API surface merged
into chat since v0.8.3 that has not been released yet — the reminder response
rename, member_custom_on_mentioned_users_enabled, mentioned_channel_members,
create_users and privacy_settings among them. That is inherent to regenerating
the client and is what the post-release SDK regeneration would produce anyway.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JimmyPettersson85
JimmyPettersson85 marked this pull request as draft August 31, 2026 21:24
@JimmyPettersson85
JimmyPettersson85 marked this pull request as ready for review September 1, 2026 08:36
@JimmyPettersson85
JimmyPettersson85 merged commit c43a480 into main Sep 1, 2026
10 checks passed
@JimmyPettersson85
JimmyPettersson85 deleted the feature/feeds-1843-default-follower-role-per-group branch September 1, 2026 08:36
JimmyPettersson85 pushed a commit that referenced this pull request Sep 1, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.8.4](v0.8.3...v0.8.4)
(2026-09-01)


### Features

* add default_follower_role to feed group API
([#342](#342))
([c43a480](c43a480))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants