Repository navigation
Add Call.UseSFU to join an SFU without the coordinator - #4
Merged
Merged
Conversation
UseSFU takes SFU credentials obtained elsewhere, for example from a coordinator JoinCall made by the caller or a locally running SFU, and joins it directly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tbarbugli
force-pushed
the
feature/use-sfu-directly
branch
from
September 30, 2026 20:20
3111116 to
d0fe8b6
Compare
tbarbugli
marked this pull request as ready for review
September 30, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Call.UseSFU(models.Credentials), which points a call straight at an SFU with credentials the caller already holds, soJoinskips the coordinator's join-call request.This is for development, tests and benchmarks against a locally running SFU (no coordinator to hand out an SFU and token), or when the caller has already made the coordinator request itself and wants to pin an SFU. Production calls should keep getting both from the coordinator. It must be called before
Join; reconnects and migrations keep using the same credentials, since there is no coordinator to ask for new ones.Tested: GitHub Actions is blocked by org billing, so CI doesn't run on this PR; locally,
make cipasses on the branch rebased ontofactory/3rtt, and newTestUseSFUJoinsWithoutTheCoordinatorjoins a fake SFU with no coordinator configured.go build ./...,go vet ./..., gofumpt,go mod tidyandgo test -race -count=1 ./...pass on the branch.🤖 Generated with Claude Code