Bring WARP (#6) into factory/3rtt - #12
Merged
Merged
Conversation
Replace pion/webrtc, pion/ice, pion/dtls/v4 and pion/sctp with the GetStream forks that implement WARP (draft-uberti-tsvwg-warp), and move to dtls/v4. Every peer connection now offers DTLS 1.2 to 1.3 and DTLS in the ICE checks (SPED); the SFU decides in band. An SFU without WARP answers as before, so there is one code path and nothing for callers to configure. The ICE fork also nominates on the first successful check against the ICE-lite SFU instead of waiting for the next check tick. The local network delay layer (internal/netdelay) moves to pion/transport/v5 with pion/webrtc v4.2.22. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pion's ICETransport.GetSelectedCandidatePairStats reads the transport's gatherer without its lock, and ICETransport.Start sets it. With SPED, Start runs inside the DTLS start, concurrently with the join trace polling the RTT, and the race detector caught it in video-sfu's end-to-end suite. ICE connected is reported after Start, so reading from then on is ordered after the write. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…E-lite SFU ICE on each peer connection connects one round trip after the first check instead of two. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
pion answers an ICE-lite offerer passive, which made the SFU the DTLS client on the subscriber peer connection. Its ClientHello could then only ride the responses to our checks, one datagram each. Answering active to a SPED offer puts our one-datagram ClientHello in our first check, as browsers do, so the subscriber is connected when ICE is. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Build on the GetStream pion forks and always offer WARP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6 (build on the GetStream pion forks and always offer WARP) was merged into its stacked base
feature/skip-hello-verifyafter #3 had already landed, so it never reachedfactory/3rtt. This merges that branch intofactory/3rtt(no conflicts).The resulting tree is identical to
3rtt/staging-all(88f1727), the build measured on staging on 2026-10-01: with fast join (#11), warm publish/subscribe went from 436 / 599 ms to 191 / 218 ms from us-east5. Without the pion forks, fast join keeps pion-ice's ~200 ms check interval.go vetandgo test ./...pass locally (GitHub Actions is blocked by billing).Please merge with a merge commit (not squash): Vision-Agents #693 pins this branch head (80e955d).